agronholm / typeguard / 10974657396

95%

push

github

Use get_protocol_members in protocol checking (#490)

This changes `check_protocol()` to make use of `get_protocol_members` from typing-extensions. This allows removing an existing hard-coded exclusion list for attributes existing on Protocol, but also handles the cases `__orig_bases__` and `__weakref__` that was breaking when checking intersecting protocols (a subclass of two or more protocols).

This has the effect of turning some false positives into true negatives, but it also leaves some false negatives. To make that clear, xfail test cases are added for the resulting false negatives.

5 of 7 new or added lines in 1 file covered. (71.43%)

1564 of 1660 relevant lines covered (94.22%)

6.4 hits per line