rust-bitcoin / rust-bitcoin / 10951959468

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3364: Remove unused inports, and fix unused variables and methods in docs

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/f6abdcc001cd0ecddec48e753c2009121036e5f6">f6abdcc00<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/855c4bb754469c726f1a83bd4bf64da8ed14085e"> Allow unused in `macros.rs` docs (Jamil Lambert, PhD)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fd89ddf4012c4dbfce07450b868dfdbcb0d6b2e6">fd89ddf40</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/855c4bb754469c726f1a83bd4bf64da8ed14085e"> Remove or fix unused variables and methods in docs (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/ff6b1d4f19d2c34c100ff2c291f5cbb49b4b6bd6">ff6b1d4f1</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/855c4bb754469c726f1a83bd4bf64da8ed14085e"> Remove unused variables and methods from docs (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/e58cda6f92b8855d6bed1ebed76bdbf8030367a0">e58cda6f9</a> Remove `unused_imports` in docs (Jamil Lambert, PhD)

Pull request description:

  As mentioned in #3362 examples in documentation are not linted in the same way as other code, but should still contain correctly written code.

  #![doc(test(attr(warn(unused))))] has been added to all lib.rs files

  In the docs throughout all crates:

  - Unused imports have been removed.

  - Unused variables, structs and enums have been used e.g. with an `assert_eq!` or prefixed with `_`

  - Unused methods have been called in the example code.

ACKs for top commit:
  tcharding:
    ACK f6abdcc001cd0ecddec48e753c2009121036e5f6
  apoelstra:
    ACK f6abdcc001cd0ecddec48e753c2009121036e5f6 successfully ran local tests

Tree-SHA512: c3de1775e6a6ccbf3a94fd25db9e1388277

18933 of 22901 relevant lines covered (82.67%)

16260.03 hits per line