couchbase / sync_gateway / 202

65%

master: 64%

Build Type

push

jenkins

Committed by web-flow

Commit Message

CBG-4179 check early for context cancellation (#7079)

* CBG-4179 check early for context cancellation

* clarify options.ChangesCtx

* Switch to use ChangesOptions.ChangesCtx

* do not expect an error message ChangesEntry.Err if context is cancelled

- ChangesFeed.Err is checked in a few places
    - GenerateChanges checks entry.Err and only serves to exit the
      function, it won't return that entry. If there is no end entry, it
      will hit <-options.ChangesCtx.Done() and set forceClose.
    - TestChannelQueryCancellation checked the error but this was
      unnecssary since the assertions are that the changes feed exits
      with only one ViewQuery
- drop error return from generateBlipSyncChanges since it was unused
- move DatabaseContext.GetChanges test only function to test only code
  since it has particular use cases.
     - require that there is no error so the caller doesn't have to
       check since it was only used for TestChannelQueryCancellation
- slight behavior change to set forceClose in
  GenerateChanges/sendSimpleChanges to check
  for context cancellation in the case that the ChangesEntry.Err was hit
  first, so this marks this as forceClose. forceClose is used to call
  DatabaseContext.NotifyTerminatedChanges to wake other changes feeds.

* add force close

Run Details

38 of 57 new or added lines in 3 files covered. (66.67%)

13 existing lines in 5 files now uncovered.

36520 of 56223 relevant lines covered (64.96%)

0.74 hits per line