MITLibraries / alma-creditcardslips / 10946501804

100%

main: 100%

Pull #272

github

Update Config module to current conventions

Why these changes are being introduced:
* Use a central Config class for dynamic access to
environment variables and simplify method for configuring
loggers.

How this addresses that need:
* Create a Config class for dynamically accessing environment variables
* Deprecate load_alma_config and update AlmaClient to use Config class to dynamically
set attributes (base_url, headers, timeout)
* Update configure_logger to use 'verbose' boolean flag
* Update CLI to accept '-v/--verbose' boolean option and remove '-l/--log-level' string option
* Add/update corresponding unit tests

Side effects of this change:
* Remove LOG_LEVEL as an optional environment variable

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1065

40 of 40 new or added lines in 4 files covered. (100.0%)

203 of 203 relevant lines covered (100.0%)

1.0 hits per line