safe-global / safe-smart-account / 10945831503

94%

push

github

Update `SafeMigration` tests for zkSync (#833)

This PR:
- Partially solves
https://github.com/safe-global/safe-smart-account/issues/767 (test
updates for `SafeToL2Upgrade` are still pending)
- It is based on version 1.5.0 because 1.4.1 cannot be compiled at the
moment because we used `.send` in there, and hardhat zksync compiler
plugin needs to be updated to support suppressing errors. I will
cherry-pick it later.
- I updated the `deployContract` function name and return type to be
more self-explanatory
- The main changes were around adding zksync compatible bytecode and
also using the ContractFactory from the "zksync-ethers" package because
in ZkSync you need to interact with a system contract to deploy
contracts and not just send a transaction with the bytecode and
`to` address omitted.

One bug found: https://github.com/matter-labs/hardhat-zksync/issues/1420

259 of 292 branches covered (88.7%)

Branch coverage included in aggregate %.

396 of 408 relevant lines covered (97.06%)

100.56 hits per line