MyIntervals / emogrifier / 10927064312

96%

push

github

[CLEANUP] Add `CssInliner::querySelectorAll` method (#1316)

This `private` method provides functionality that is used in three separate
places (albeit a one-liner), and includes taking care of exception handling
according to the debug mode setting.

The new method and parameter names match the equivalent in the
[Web API](
  https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelectorAll
).

There will be a tiny performance impact due to additional method calls.  But the
benefits include code re-use and common error handling.

Also add `ensureNodeIsElement` method for use with the result from
`querySelectorAll` to ensure type safety.  `querySelectorAll` should always
return a `DOMNodeList` of `DOMElement`s.  But this cannot be guaranteed if there
is a bug in CssSelector whereby it returns an XPath expression which may match
non-element nodes.  And it would (probably) be sub-optimal for
`querySelectorAll` to have an extra loop checking this, when it can be done in
the caller's loop over the returned data.

21 of 29 new or added lines in 1 file covered. (72.41%)

761 of 785 relevant lines covered (96.94%)

274.23 hits per line