sapcc / limes / 10923353774

80%

push

github

Add POST API to convert a commitment to a target Resource (#554)

* Add first logic pieces to convert a commitment

* Rebase with master
get source and target behaviors with the newly integrated methods from limes

* Add azResourceID resolution

* Add check where amount does not match conversion rate

* Utilize location query

* Add first unit tests

* Add remaining cases to consider during conversion
Implement remaining unit tests

* Add documentation

* Adjust API URL path to match the internal system
integrate commitment by id select into an inline version

* Update internal/api/commitment.go

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>

* Update internal/api/commitment.go

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>

* Update internal/api/commitment.go

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>

* Add unit test for invalid conversion to a different identifier

* Remove superfuous error message return on findDomain and findProject queries

* Supersede old commitment
create a remainder commitment and a conversion commitment instead of changing the amount of the original one

* Fix documentation

* fix documentation

* Update internal/api/commitment.go

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>

* Allow unconfirmed commitments to be converted

* Fix unit tests

* Only allow commitment conversion for the project the user has rightfully access to
utilize findProjectCommitmentByIDQuery: it matches the origin of the commitment with the project ID
attempted transfers to a different project will be rejected

* Adjust name mapping to master implementation

* Adjust error message on conflicting conversion config

* Reject conversion attempts early
check against serviceType and resourceName before having a check in depth via the azResourceID

* Uncommittable resources should still allow conversions
Remove the corresponding guard clauses.... (continued)

151 of 199 new or added lines in 3 files covered. (75.88%)

5166 of 6572 relevant lines covered (78.61%)

64.23 hits per line