babelfish-for-postgresql / babelfish_extensions / 10900503761

74%

BABEL_5_X_DEV: 77%

push

github

fix valgrind warnings in alter function (#2936) (#2938)

References to list cell become invalid after calls to list_delete_cell().
In alter function statement we were referencing the return_cell across call to list_delete_cell(). list_delete_cell() completely copies a list to new location when VALGRIND is enabled which meant that return_cell was no longer valid.
As a fix we use foreach_delete_current to delete the defelem inside the foreach loop and skip maintaining a list cell pointer altogether.

Issues Resolved: [BABEL-5249]

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

8 of 8 new or added lines in 2 files covered. (100.0%)

42722 of 58021 relevant lines covered (73.63%)

139578.23 hits per line