PHPCSStandards / PHP_CodeSniffer / 10861789063

78%

master: 79%

push

github

Squiz/DisallowMultipleAssignments: bug fix - dynamic property assignment on object stored in array

The sniff would try to find whether the first "relevant" variable found matches the start of the statement and if not, throw an error, but in the case of dynamic property access on objects stored in an array, the first "relevant" variable determination was off and would get stuck on the `]` close bracket of the array access.

Fixed now. Includes ample tests.

This should also make the sniff slightly more efficient for property access code snippets which the sniff already handled correctly.

Fixes 598

4 of 4 new or added lines in 1 file covered. (100.0%)

18002 of 24310 relevant lines covered (74.05%)

71.32 hits per line