rust-bitcoin / rust-bitcoin / 10853108490

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3194: priority: Prepare moving script types to `primitives`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/8f2f4cbb3cf172907367f78f440fd5ebb32d422c">8f2f4cbb3<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/60e15b800705cf0802feb777620f780939132d3a"> Re-order optional dependencies (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/95f2a8dab61aa238e3a2244095f01a66b888fba8">95f2a8dab</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/60e15b800705cf0802feb777620f780939132d3a"> Do not access ScriptBuf inner from builder (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/900af453ff3cfb789aca7e1e3fc5689d40bb5c51">900af453f</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/60e15b800705cf0802feb777620f780939132d3a"> Stop accessing inner ScriptBuf field when encoding (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8b82363d97b6d1d69fe216843bc6ad1c52e275c2">8b82363d9</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/60e15b800705cf0802feb777620f780939132d3a"> Use Script::as_bytes instead of inner when indexing (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b0675a4a4f5b5a60bfa72bce990e91aef70500cd">b0675a4a4</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/60e15b800705cf0802feb777620f780939132d3a"> Use Script::len instead of inner field (Tobin C. Harding)
374c6118d Deprecate Script::fmt_asm and to_asm_str (Tobin C. Harding)

Pull request description:

  Move the `Script` and `ScriptBuf` types to `primitives`. There were still a few preparations required, things we had missed while creating the extension traits.

  Note also please, in the last patch, we enable `hex` from the `serder` feature. This is not the final state we want but like we did for `alloc` it is a step to reduce the size of the diff.

ACKs for top commit:
  Kixunil:
    ACK 8f2f4cbb3cf172907367f78f440fd5ebb32d422c
  apoelstra:
    ACK 8f2f4cbb3cf172907367f78f440fd5ebb32d422c successfully ran local tests

Tree-SHA512: 62a5f3c253bca2044460ff3e957cacd17d7

Coverage Stats

39 of 44 new or added lines in 4 files covered. (88.64%)

5 existing lines in 1 file now uncovered.

18905 of 22846 relevant lines covered (82.75%)

16315.36 hits per line