trento-project / web / 37aa3037bdc91fdf5a6cf9016a89c41ec9642ebf

88%

push

github

Activity log filter by user (#2924)

* wip

- needs some clean up

* See description

- Deletes unused code
- Pulls out state access into the ActivityLog page context

* More code deletion; Adds user context function

- Deletes unnecessary code from the composed filter
- Adds a new function the users context
- Adds needed context calls to the ActivityLog channel module

* Renaming

Renames some declarations

* Refactors activity_log channel

* Fixes warning

Fix for identityFunctionCheck warning in console.

* Runs formatter

* Renaming

* Adds some tests

- channel test for activity log
- activity log state test

* Runs js code formatter

* Fix for failing tests

Adds a hook that passes in requisite state to the ActivityLogPage component

* Deletes an unused import; format

* Some cleanup

Specific users in list are not necessary

* Adds a system user

Previously a system user was not returned; now it is possible to filter the system activity log entries.

* Refactors ActivityLogPage test

* Adds test for activityLog users selector

* Adds tests for ActivityLogChannel

* Adds a test for a Users context function

* Addresses PR comments

Renaming

* Handles scenario with deleted users

Collapses usernames from deleted users into a username without timestamp suffix

* Renaming

alUsers -> activityLogUsers

* Adds test case for non-empty initial state

* Formatting

* Makes refresh interval a parameter

According to PR conversation, the update push interval from the channel  is now a compile time Application env variable.

* Addresses PR comment

The users context function modified here now returns username tupled with the deleted_at timestamp. This simplifies somewhat the implementation of the collapse_usernames function in the ActivityLogChannel module. Specifically, this function no longer needs to do any DateTime parsing to infer soft deleted users/associated usernames.... (continued)

14 of 16 new or added lines in 2 files covered. (87.5%)

2777 of 3290 relevant lines covered (84.41%)

229.26 hits per line