skeema / skeema / 10839881432

92%

push

github

text: change "instance" to "database server" for consistency

This commit tweaks the wording of logging, help text, and error messages to
prefer "database server" instead of "instance". Previously, a mix of these
two terms was used, which could cause confusion. We now prefer "database
server" (or equivalently "DB server") to refer to a copy of MySQL Server or
MariaDB Server running on a specific host and port. Although "instance" is
common terminology on cloud vendors ("RDS instance", "CloudSQL instance",
etc) overall that term seems less clear because e.g. an "EC2 instance" can
also be the client side / where Skeema runs from.

This change is being made now ahead of a planned new documentation page, which
will cover core concepts and terminology.

A few places intentionally still use "instance" even after this commit:

* The concurrent-instances option for `skeema push` remains as-is for
  backwards compatibility.
* The "-- instance: ..." comment in STDOUT output of `skeema diff` and
  `skeema push` remains as-is, since some users parse this text.
* Some internal-only error messages still use "instance", since the internal
  struct type tengo.Instance isn't being renamed.

The first two might change in a future major-version bump (e.g. Skeema v2)
if/when that happens, but no concrete plans at this time.

This commit also adjusts some other unrelated help text, for example now
preferring "command-line arg" over "CLI arg".

32 of 34 new or added lines in 11 files covered. (94.12%)

9989 of 10714 relevant lines covered (93.23%)

1.11 hits per line