Qiskit / qiskit / 10838928352

88%

Build Type

push

github

Committed by web-flow

Commit Message

Move `Option<Box<_>>` into `ExtraInstructionAttributes`. (#13127)

* Move Option<Box<_>> into ExtraInstructionAttributes.

Previously, CircuitInstruction and PackedInstruction held
the ExtraInstructionAttributes struct within an Option<Box<_>>.
By putting the Option<Box<_>> inside ExtraInstructionAttributes,
we can use the struct itself to manage its memory and provide
access to the attributes behind a nicer interface.

The size of ExtraInstructionAttributes should be the same size
as the old Option<Box<ExtraInstructionAttributes>>, so this
should not have memory implications.

* Address review comments.

- Use tuple struct.
- Use 'Attributes' over 'Attrs'.
- Add doc comment for internal 'ExtraAttributes' struct.
- Add doc comments for methods.
- Add setters for unit and duration.

* Fix performance regression from unnecessary dict creation.

Run Details

107 of 164 new or added lines in 8 files covered. (65.24%)

20 existing lines in 6 files now uncovered.

73439 of 82603 relevant lines covered (88.91%)

360737.53 hits per line