10819642591
88%

Ran 11 Sep 2024 09:26PM UTC

Jobs 1

Files 883

Run time 2min

Badge

Embed ▾

Committed 11 Sep 2024 09:04PM UTC coverage: 88.854%. Remained the same

Build # 10819642591

Build Type

push

github

Committed by

web-flow

Commit Message

Fix ABI3 issues identified during 1.3.0b1 release attempt (#13136)

We recently tried to publish the 1.3.0b1 release unsucessfully. During
the wheel build jobs abi3audit was failing because it correctly
identified a couple of abi violations in the builds. The first was we
were tagging the package incorrectly as being with a minimum level of
Python 3.8 instead of the correct minimum of 3.9. This commit updates
the setup.py tag to match the package metadata with the binary.

The second issue is we were creating `PyInit_*` symbols for submodules
which goes against the abi3 naming recomendations and abi3 audit flags
it as a violation. We had this issue previously in 1.2.0 but was fixed
for that release. However since 1.2.0 and now several stray usages of
`#[pymodule]` on submodules slipped in during development. This commit
fixes those so the bad symbol names won't be created anymore.

Once this commit merges we should tag the new commit as 1.3.0b1.

Co-authored-by: Raynel Sanchez <87539502+raynelfss@users.noreply.github.com>

Run Details

73105 of 82275 relevant lines covered (88.85%)

363389.1 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
3	91.98	0.25%	crates/qasm2/src/lex.rs
6	97.15	-0.46%	crates/qasm2/src/parse.rs

Jobs

ID	Job ID	Ran	Files	Coverage
1	10819642591.1	11 Sep 2024 09:26PM UTC	883	88.85	GitHub Action Run

Qiskit / qiskit / 10819642591
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 10819642591

Qiskit / qiskit / 10819642591 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 10819642591

Qiskit / qiskit / 10819642591
88%

README BADGES
x