stacklok / minder / 10818533147

53%

Build Type

push

github

Committed by web-flow

Commit Message

Handle calling the property service in transaction better (#4434)

* Pass a transaction handle to RetrieveAllProperties and RetrieveAllPropertiesForEntity

These interface methods wouldn't take transaction into account.

Related: #4393

* Call an explicit commit in ListEvaluationHistory handler

We refresh the properties in the historical evaluation endpoint (which
btw should just be temporary to convert from the old tables to the new
general tables) and missed the fact that the handler starts a
transaction and then always rolls back - that was probably a way to keep
consistence.

This means that the transactions that refresh properties are rolled back
and on next call fetched again. This hurts performance quite a bit on
repeated listHistory calls.

Fixes: #4393

Run Details

35 of 52 new or added lines in 7 files covered. (67.31%)

1 existing line in 1 file now uncovered.

13597 of 25419 relevant lines covered (53.49%)

44.21 hits per line