rust-bitcoin / rust-bitcoin / 10815518805

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3295: internals: Fix lint warnings on macro

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/514cc5500f47d78e3b708a6a6a9c7aeea37d1728">514cc5500 internals: Fix lint warnings on macro (Tobin C. Harding)

Pull request description:

  The new `impl_to_hex_from_lower_hex` macro causes build warnings when `internals` is built without the `alloc` feature.

  There are two macro implementations depending on feature gates, duplicate the rustdocs from the other one.

  While we are at it reduce the lines of code for the empty case.

ACKs for top commit:
  Kixunil:
    ACK 514cc5500f47d78e3b708a6a6a9c7aeea37d1728
  apoelstra:
    ACK 514cc5500f47d78e3b708a6a6a9c7aeea37d1728 successfully ran local tests

Tree-SHA512: f6a8929f5de417a1cb482a05c9e0243e2a1

18911 of 22845 relevant lines covered (82.78%)

16391.37 hits per line