rust-bitcoin / rust-bitcoin / 10793474025

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3259: priority: Introduce and use a new `compact_size` module

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/d65de7c7dec550a3726a2d9f27d35ff934a5f9c5">d65de7c7d Introduce and use new compact_size module (Tobin C. Harding)

Pull request description:

  We would like to move the witness module to `primitives` but there is a bunch of usage of `VarInt`.

  Introduce a module that does the encoding and decoding instead, note that while the functionality is internal decoding returns an error which may one day end up in the public API. So put the module in `primitives` and make it public.

  Adds the module to `primitives`, adds a public `MAX_ENCODABLE_SIZE` variable that is commented with an issue link.

  https://github.com/rust-bitcoin/rust-bitcoin/issues/3264

ACKs for top commit:
  apoelstra:
    ACK d65de7c7dec550a3726a2d9f27d35ff934a5f9c5 successfully ran local tests
  Kixunil:
    ACK d65de7c7dec550a3726a2d9f27d35ff934a5f9c5

Tree-SHA512: d9483c29be773f4356a54de47b78493c81c

135 of 140 new or added lines in 2 files covered. (96.43%)

18911 of 22845 relevant lines covered (82.78%)

16358.19 hits per line