rust-bitcoin / rust-bitcoin / 10779936873

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3128: hashes: Remove `io` feature

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/ae93e226e359d0228fdff05559499198a38b2144">ae93e226e Remove hashes io feature (Tobin C. Harding)

Pull request description:

  Currently we only get `std::io::Write` impls when the `bitcoin-io` dependency is used. This is overly restrictive, it would be nice to have `std::io::Write` imlps even without the `bitcoin-io` dependency.

  Copy the logic out of the `bitcoin_io::impl_write` macro into `hashes` but feature gate it differently.

  Call the new macro inside `hash_type` (and in `hmac`), remove the `impls` module, and move the tests to the integration test directory.

  Remove the `io` feature from `hashes`, now if users enable `std` they get `std::io::Write` impls and if they enable `bitcoin-io` they get `bitcoin_io::Write` impls as well.

ACKs for top commit:
  Kixunil:
    ACK ae93e226e359d0228fdff05559499198a38b2144
  apoelstra:
    ACK ae93e226e359d0228fdff05559499198a38b2144 successfully ran local tests

Tree-SHA512: d47c9c0605e575f36b7d46affc96ece09e4

11 of 22 new or added lines in 2 files covered. (50.0%)

18771 of 22701 relevant lines covered (82.69%)

16516.68 hits per line