curationexperts / laevigata / d581ef99-699b-428a-891e-ce2c097dc595

97%

Build Type

push

circleci

Committed by mark-dce

Commit Message

[REFACTOR] Consolidate similar embargo logic

**RATIONALE**
The application had specific code to translate the Rails embargo
settings into a format usable by the JavaScript ETD forms that
was very similar to existing logic in the VisibilityTranslator class.

Having aligned terminology in the JavaScript and Rails portions of
embargo handling code in previous refactorings, we can now use the
logic from `VilibilityTranlator` class directly and eliminate the
need for the `EmbargoTypeFromAttributes` class.

**NOTE**
This change also significantly speeds up these tests (20s --> 2s)
by replacing FactoryBot `.create` calls with `.build` calls
since none of the tests require the objects to be stored to the
database or Fedora.

Run Details

6 of 6 new or added lines in 3 files covered. (100.0%)

349 existing lines in 30 files now uncovered.

3027 of 3225 relevant lines covered (93.86%)

51.51 hits per line