rust-bitcoin / rust-bitcoin / 10777476313

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3293: priority: Re-write (and re-name) `read_uint_iter`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/0f897f80a5e2660f6e32e906850fcdd0502ab2a4">0f897f80a Re-write (and re-name) read_uint_iter (Tobin C. Harding)

Pull request description:

  The `UintError` type (returned by `read_uint_iter`) is not that useful because one variant is unreachable. Re-write the function by doing:n

  - Re-write the function to reduce the error cases returned.
  - Re-name it to `read_push_data_len`
  - Move it to `internals`
  - Use `PushDataLenLen` enum instead of an int parameter

ACKs for top commit:
  apoelstra:
    ACK 0f897f80a5e2660f6e32e906850fcdd0502ab2a4 successfully ran local tests; lol so much better than the old code
  Kixunil:
    ACK 0f897f80a5e2660f6e32e906850fcdd0502ab2a4

Tree-SHA512: 095017a3241295f149aa178434337e8e1bc

Coverage Stats

40 of 40 new or added lines in 3 files covered. (100.0%)

1 existing line in 1 file now uncovered.

18836 of 22772 relevant lines covered (82.72%)

16292.27 hits per line