LudovicRousseau / pyscard / 10759141755

67%

Build Type

push

github

Committed by LudovicRousseau

Commit Message

Fix use of undefined variable 'hresult' in exceptions

The following commit introrudced the inclusion of hresult in
exceptions that are raised:

commit 395cdc46a
Author: Ludovic Rousseau <ludovic.rousseau@free.fr>
Date:   Sun Apr 23 18:27:24 2023 +0200

However, it also introduces hresult into 'raise' statements where
no hresult exists [yet].  This in turn causes double exceptions like
this:

Traceback (most recent call last):
  File "/crypt/space/home/laforge/projects/git/pysim/./contrib/card2server.py", line 106, in <module>
    'atr': tp.get_atr(),
           ^^^^^^^^^^^^
  File "/crypt/space/home/laforge/projects/git/pysim/contrib/pySim/transport/pcsc.py", line 95, in get_atr
    return self._con.getATR()
           ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/smartcard/CardConnectionDecorator.py", line 66, in getATR
    return self.component.getATR()
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/smartcard/CardConnectionDecorator.py", line 66, in getATR
    return self.component.getATR()
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/smartcard/pcsc/PCSCCardConnection.py", line 215, in getATR
    hresult=hresult)
            ^^^^^^^
UnboundLocalError: cannot access local variable 'hresult' where it is not associated with a value

Run Details

0 of 2 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

850 of 2949 relevant lines covered (28.82%)

0.29 hits per line