rust-bitcoin / rust-bitcoin / 10746115599

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3301: Deprecate `from_slice` methods in favor of arrays

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/c00afe8d521ee712461058a1a8b0235706e77bfd">c00afe8d5<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/9afeb711e43c3ed3754457a4aedeb43025160731"> Change MessageSignatureError to secp256k1::Error (Jamil Lambert, PhD)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a20d0bc4eb380b025a66aa8dcc106fc6bebc72bb">a20d0bc4e</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/9afeb711e43c3ed3754457a4aedeb43025160731"> Deprecate `from_slice()` in sha256.rs (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/089043546f76835e2490dc425c7e128c6610d2aa">089043546</a> Deprecate `from_slice` methods in favor of arrays (Jamil Lambert, PhD)

Pull request description:

  As brought up in issue #3102 support for Rust arrays is now much better so slice-accepting methods that require a fixed length can be replaced with a method that accepts an array.

  `from_slice()` methods that require a fixed length have been deprecated and where needed a `from_byte_array()` method created that accepts an array.

  There are still `from_slice` methods that rely on changes to external crates before they can be changed to arrays.

ACKs for top commit:
  apoelstra:
    ACK c00afe8d521ee712461058a1a8b0235706e77bfd successfully ran local tests
  tcharding:
    ACK c00afe8d521ee712461058a1a8b0235706e77bfd
  Kixunil:
    ACK c00afe8d521ee712461058a1a8b0235706e77bfd

Tree-SHA512: c505b78d593edc6ac135d7f6c2bb75d3809

15 of 22 new or added lines in 2 files covered. (68.18%)

18815 of 22749 relevant lines covered (82.71%)

16366.89 hits per line