safe-global / safe-smart-account / 10726489528

94%

push

github

Feature: add zksync support to v1.5.0 (#742)

**This PR:**
- Implements
https://github.com/safe-global/safe-smart-account/issues/766 by adding
the zksync support for deployment and testing contracts
- It is based on
https://github.com/safe-global/safe-smart-account/pull/651. However,
Matter Labs has published many updates in the meantime, so there are
many changes
- Add zksync tests to the CI

**Importants changes**
- The zksync team did a great job of adding a lot of interoperability
features with hardhat's environment ethers object, however, there are
certain features we rely on that require zksync-specific adjustments,
such as compiling code from string, contract deployment, create2 address
calculation. Functions specific to that had to be adjusted
- we had incorrect test assumptions: for example, we assumed that
`hre.ethers.getContractAt` would always return a contract instance
connected to the first account returned from `hre.ethers.getSigners`.
This didn't hold in zksync environment as they use the 9th account

**Notes**
- This PR doesn't include changes to Safe Migration contract tests for
zksync, as we decided to merge this first and add the support to 1.4.1
and fix the migration contracts there, then cherry-pick it back to 1.5.0

**Proof of deployment:**
```
> hardhat deploy-contracts --network zkSyncSepolia

Yul codegen is only supported for solc >= 0.8. Flag forceEVMLA will automatically be set to true by default.
Yul codegen is only supported for solc >= 0.8. Flag forceEVMLA will automatically be set to true by default.
The zksolc compiler version in your Hardhat config file (1.5.2) is not the latest. We recommend using the latest version 1.5.3.
Nothing to compile
No need to generate any newer typings.
reusing "SimulateTxAccessor" at 0x1aaa95173dAA2F9B18df1277485CAd842Bb5EeFe
reusing "SafeProxyFactory" at 0x9c8588F1Cfbf54845c06C6924E90b20AB0912B6F
reusing "TokenCallbackHandler" at 0x94AA81a0E2e857A0e597... (continued)

259 of 292 branches covered (88.7%)

Branch coverage included in aggregate %.

386 of 398 relevant lines covered (96.98%)

102.95 hits per line