projectblacklight / blacklight / 3406
49%

Ran 12 Jul 2016 01:24AM UTC

Jobs 4

Files 216

Run time 20min

Badge

pending completion

Build # 3406

Build Type

push

travis-ci

Committed by

Commit Message

Clean up rspec files (#1437)

* Cleanup and conventionalization

- Avoid `any_instance_of`.
- Single line `let` syntax.
- Cut trailing whitespace and extraneous line-breaks.
- Combine before blocks of the same scope.

* Remove obsolete, unused opts file

Our current versions of rspec use the `.rspec` options file.

* Update Devise behavior conditional

This mimics the change from spotlight:
https://github.com/projectblacklight/spotlight/commit/cc9a6627c#diff-93830fa29d616f7c87903d08b5b1b29aR71

Without it, a developer instance could still get the failure:
```
uninitialized constant Devise::Test (NameError)
```

when using Rails 5.x and Devise `4.1.1`. (Devise 4.2.0 resolves it, but
the point is to avoid constraining versions of Devise.)

* Cleanup blacklight_helper_spec

- Remove inline `include` statements, including for *this* class!
- Replace `def` definitions with targetted let/allow statements.
- Use common `let`/`before` blocks, with `context` grouping as needed.
- Make unimplemented test explicitly pending.

* Use .rspec advantageously

Require spec_helper once instead of 100 times.
PS: not British.

* Cleanup facets_helper_spec

- Remove class instance `@variables` (where possible)
- Make use of `let` statements for `blacklight_config`, since the top
allow statement is already connecting it to the helper.
- Use single-quoted strings instead double-quoted escaped double-quotes.
- Rubocop friendly spaces after commas and such.
- Other common `let` statements in a few economical cases.

* Stop using fork of Deprecation in test app

Run Details

3074 of 3990 relevant lines covered (77.04%)

2503.24 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	3406.1 (2.3.1, RAILS_VERSION=5.0.0)	12 Jul 2016 01:24AM UTC	137	94.29	Travis Job 3406.1
2	3406.2 (2.3.1, RAILS_VERSION=4.2.6)	12 Jul 2016 01:24AM UTC	134	94.25	Travis Job 3406.2
3	3406.3 (2.2.5, RAILS_VERSION=5.0.0)	12 Jul 2016 01:24AM UTC	137	94.32	Travis Job 3406.3
4	3406.4 (jruby-9.0.5.0, RAILS_VERSION=4.2.6 JRUBY_OPTS="-J-Xms512m -J-Xmx1024m")	12 Jul 2016 01:44AM UTC	210	0.0	Travis Job 3406.4

Source Files on build 3406

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line