babelfish-for-postgresql / babelfish_extensions / 10680746728

74%

BABEL_5_X_DEV: 77%

push

github

Fixed Cast from sys.varchar to TIME shows unexpected result due to undefined typmod (#2898)

While casting from varchar to TIME, shows unexpected result due to undefined typmod.
It was discovered that some test related to TIME fails randomly on arch64 machine and passed on other 32 bit machines.For query like -- select cast(cast('12:45:37.123' as varchar) as time)

Output :

32bit machines: 12:45:37.1230000
arch64: 12:45:37.0000000

Expected result : 12:45:37.1230000

Reason: Junk value for arch32 is set to a value greater then 7. So it will read real value till 7, Whereas in arch64 junk value is set to 0 due to some compiler optimisation. It won't read any value after '.' setting it to zero.

Changes made to fix the issues --

time_in function was called from varchar2time function with one argument whereas time_in function expects 3 arguments, 3rd one beign the typmod. As this argument was not passed it was picking junk value. This is fixed by calculating tymod in varchar2time and passing correct value of typmod to time_in function.
Also added test cases for this purpose.

Task: BABEL-5179
Signed-off-by: yashneet vinayak <yashneet@amazon.com>

4 of 4 new or added lines in 1 file covered. (100.0%)

42667 of 57963 relevant lines covered (73.61%)

140311.25 hits per line