evolution-gaming / prometheus-tools / 10678211517

43%

master: 43%

Build Type

Pull #6

Committed by migesok

Commit Message

Migrate to nanoTime for time* methods, improve API DX

timeFunc and timeFuture used millisecond precision, which lead to issues like
Summary quantiles being skewed towards 0 if measured latencies are close to 1 ms.

To fix that:
- time* methods use System.nanoTime() now
- deprecate specific time*Nano methods, millisecond precision shouldn't be a choice to avoid mistakes
- improve method naming, document all time-related public functionality
- deprecate unused TemporalOps implicit conversion
- overall developer experience improvements

This change breaks source compatibility for some usages, but binary compatibility is preserved.

Pull Request Pull Request #6: Migrate to nanoTime for time* methods, improve API DX

Run Details

15 of 29 new or added lines in 3 files covered. (51.72%)

1 existing line in 1 file now uncovered.

23 of 53 relevant lines covered (43.4%)

0.66 hits per line