shinghim / rust-bitcoin / 10672954414

84%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3275: Enforce that `Hash::Bytes` is an array

<a class=hub.com/shinghim/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/shinghim/rust-bitcoin/commit/be133975703f3a62d37fffc554f6d868d445b0a1">be1339757<a href="https://github.com/shinghim/rust-bitcoin/commit/9233eb2fa329864e9c5f5651f60f5f8cde52bc91"> Make hmac & hkdf more robust against buggy `Hash` (Martin Habovstiak)
<a class="double-link" href="https://github.com/shinghim/rust-bitcoin/commit/94c0614bda8bca6077e76fbdd1414e32119a02d5">94c0614bd</a> Enforce that `Hash::Bytes` is an array (Martin Habovstiak)

Pull request description:

  This makes sure `Hash::Bytes` is an array. We've discussed this somewhere but I don't remember where.

  I'm not sure if the second commit is actually valuable but hopefully shouldn't make things worse.

ACKs for top commit:
  apoelstra:
    ACK be133975703f3a62d37fffc554f6d868d445b0a1 successfully ran local tests; yep, this looks like an improvement. Agreed that the second commit has questionable value but doe not make things worse
  tcharding:
    ACK be133975703f3a62d37fffc554f6d868d445b0a1

Tree-SHA512: 0fed98208bf01551a018d81b5d42961ae71

Run Details

12 of 12 new or added lines in 2 files covered. (100.0%)

1265 existing lines in 32 files now uncovered.

19709 of 23820 relevant lines covered (82.74%)

15574.18 hits per line