rust-bitcoin / rust-bitcoin / 10658405471

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3276: fix: deprecate wrong and unused max script num

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/345d3daa72bdbbfbe90eb6d9b9cf4932213928ca">345d3daa7 fix: deprecate wrong and unused max script num (ChrisCho-H)

Pull request description:

  ~~Script number can be up to 2^39 - 1 to encode locktime.~~
  ~~If it's only for the integer operation besides locktime, it must be 2^31 - 1, not 2^31.~~

  I agree with apoelstra  opinion to deprecate this value.

ACKs for top commit:
  apoelstra:
    ACK 345d3daa72bdbbfbe90eb6d9b9cf4932213928ca successfully ran local tests
  Kixunil:
    ACK 345d3daa72bdbbfbe90eb6d9b9cf4932213928ca

Tree-SHA512: df42054150cefa085bbb476825be5894068

19707 of 23819 relevant lines covered (82.74%)

15595.45 hits per line