rust-bitcoin / rust-bitcoin / 10649859083
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 98
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.73% (-0.01%) from 82.74%
10649859083

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#3278: Show compressed public key in Debug for CompressedPublicKey

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/9db6234ea9c9c06ad3eec746463ef6fe989a08aa">9db6234ea<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d1e7116321f7ca9820073adafc985d39e96d7f43"> Show compressed public key in Debug for CompressedPublicKey (Jiri Jakes)

Pull request description:

  Currently `CompressedPublicKey` debug produces output of form:

  ```
  CompressedPublicKey(PublicKey(<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2f8b18dc0adcb73d75f7934d9523ea7347083e41">2f8b18dc0</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c48115398cb37e295a0a6ffe86e0bf8b1ef65888">c48115398</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c880c8d8813a30e69e466380cbe2daec18f3ed1e">c880c8d88</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d1e7116321f7ca9820073adafc985d39e96d7f43">7a553ff2))
  ```

  Although it shows real internal structure together with inner uncompressed public key, it is not too helpful for the purpose of debugging _compressed_ public key.

  After this patch, `Debug` output will be equal to `Display` (it, in fact, delegates rendering to `Display`), prepended by the name of the struct:

  ```
  CompressedPublicKey(02fe6f0a5954d93f7753db7dc0adc188b2f)
  ```

ACKs for top commit:
  Kixunil:
    ACK 9db6234ea9c9c06ad3eec746463ef6fe989a08aa unless other maintainers agree to drop the struct name.
  apoelstra:
    ACK 9db6234ea9c9c06ad3eec746463ef6fe989a08aa successfully ran local tests; we should keep the struct name since it is canonical for Debug output

Tree-SHA512: e2626678abc7c8ef868f7e2f6a2ca563753

0 of 3 new or added lines in 1 file covered. (0.0%)

19707 of 23821 relevant lines covered (82.73%)

15640.01 hits per line

Jobs
ID Job ID Ran Files Coverage
1 10649859083.1 0
82.73
 GitHub Action Run
Source Files on build 10649859083
Detailed source file information is not available for this build.