TuringLang / Turing.jl / 10634847007

76%

main: 84%

Build Type

push

github

Committed by web-flow

Commit Message

Fix remaining method ambiguities (#2304)

* Enabling aqua ambiguity testing for Turing


We test ambiguities only for Turing and not its dependencies.

* Format

* Fix bundle_samples method ambiguity

Concretely:

1. Creating an `AbstractTransition` type which all the Transitions in
   Turing subtype.
2. Modifying the type signature of bundle_samples to take a
   Vector{<:Union{AbstractTransition,AbstractVarInfo}} as the first
   argument. The AbstractVarInfo case occurs when sampling with Prior(),
   so the type signature of this argument mirrors that of the Sampler in
   the same function.

* Fix get() ambiguities

Done by:

1. Constraining the type parameter to AbstractVector{Symbol}
2. Modifying the method below it to use a vector instead of a tuple

* Bump to 0.34.0

---------

Co-authored-by: Abhinav Singh <73834077+abhinavsns@users.noreply.github.com>
Co-authored-by: Xianda Sun <5433119+sunxd3@users.noreply.github.com>

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

1387 of 1594 relevant lines covered (87.01%)

2171541.6 hits per line