• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

babelfish-for-postgresql / babelfish_extensions / 10631816642
74%
BABEL_5_X_DEV: 77%

Build:
Build:
LAST BUILD BRANCH: babel_5688_min
DEFAULT BRANCH: BABEL_5_X_DEV
Ran 30 Aug 2024 12:07PM UTC
Jobs 1
Files 114
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

30 Aug 2024 11:22AM UTC coverage: 73.603% (+0.2%) from 73.42%
10631816642

push

github

web-flow
Fix Error Handling and Cleanup during Insert Bulk Process (#2896)

This commit fixes an issue with the error handling and cleanup phase of the Insert Bulk Process.

1. For Error Handling there was a scenario where bulk_load_callback(0, 0, NULL, NULL) call for cleanup would flush the remaining rows during EndBulkCopy and could result in an error. To fix this, we move the transaction rollback logic from TSQL extension to TDS. We also improved it by using Savepoints in case of active transaction which is aligned with TSQL behaviour.
2. In this case, if we have a reset-connection after the Bulk Load TDS packet we werent cleaning up the Bulk Load state. To do so we reset the offset.
3. During Reset Connection TDS is not resetting any TSQL transaction semantic. To resolve this we introduce a wrapper of AbortOutOfAnyTransaction to reset NestedTranCount.
Issues Resolved
BABEL-5200, BABEL-5199, BABEL-5220

Authored-by: Kushaal Shroff kushaal@amazon.com
Signed-off-by: Kushaal Shroff kushaal@amazon.com

138 of 157 new or added lines in 6 files covered. (87.9%)

6 existing lines in 2 files now uncovered.

42648 of 57943 relevant lines covered (73.6%)

139802.25 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
19
76.16
1.82% contrib/babelfishpg_tds/src/backend/tds/tdsbulkload.c

Uncovered Existing Lines

Lines Coverage ∆ File
3
76.03
1.66% contrib/babelfishpg_tds/src/backend/tds/tdscomm.c
3
76.16
1.82% contrib/babelfishpg_tds/src/backend/tds/tdsbulkload.c
Jobs
ID Job ID Ran Files Coverage
1 10631816642.1 30 Aug 2024 12:07PM UTC 114
73.6
GitHub Action Run
Source Files on build 10631816642
  • Tree
  • List 114
  • Changed 74
  • Source Changed 6
  • Coverage Changed 13
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #10631816642
  • 69786c33 on github
  • Prev Build on BABEL_3_X_DEV (#10616570889)
  • Next Build on BABEL_3_X_DEV (#10635687945)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc