rust-bitcoin / rust-bitcoin / 10622799828

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3204: Do many cleanups (and bug fix)

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/dae42bef9de0af8d605fa73ba06f39c576732ccc">dae42bef9<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0d9e8f8c992223869a57162c4afe5a6112d08049"> do not enable bitcoin-io by default (Antoni Spaanderman)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a14cdaf8590677b6b53e275c1ea45c78183fc9a1">a14cdaf85</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0d9e8f8c992223869a57162c4afe5a6112d08049"> don&#39;t enable std by default when testing (Antoni Spaanderman)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/e83830dcfcbd47a9b9651eca539f5c38ef63eb68">e83830dcf</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0d9e8f8c992223869a57162c4afe5a6112d08049"> use slice instead of array to not have to hardcode the length (Antoni Spaanderman)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/55749d6f61446dce76bcfe555cecfa7db07bf219">55749d6f6</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0d9e8f8c992223869a57162c4afe5a6112d08049"> use `hash.to_byte_array` to check equality with `test.output` (Antoni Spaanderman)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/969864e3b0bf0aef2095a06f401370e907cd715e">969864e3b</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0d9e8f8c992223869a57162c4afe5a6112d08049"> use fixed size array if possible, otherwise `&amp;&#39;static [u8]` (Antoni Spaanderman)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/28ccf70fa66bec9608472b2c751b3347415dbcfe">28ccf70fa</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0d9e8f8c992223869a57162c4afe5a6112d08049"> remove unnecesarry borrow operator (`&amp;`) (Antoni Spaanderman)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fa3a3afd02f1d1e6901ab02b81bfab863b7835a2">fa3a3afd0 remove unnecessary slicing (Antoni Spaanderman)
22e42ab86 fix test code being unnecessarily feature gated (Antoni Spaanderman)

Pull request description:

  - remove 2 unnecessary cfg attributes from tests left over from  #3167 (it made them not dependent on `alloc` anymore)
  - simplify assertion logic by removing unnecessary conversions before comparing
  - make tests `no_std` compatible by adding imports to alloc or std
  - feature gate tests behind the `alloc` feature if they use anything from the alloc crate (like the `format!` macro)
  - `schemars` feature enables `alloc` because (for example) its trait wants implementations to return `String`
  - fix `bitcoin-io` always enabling when `std` is enabled (only useful if people depend on `hashes` only, `bitcoin` depends on `bitcoin-io` already)

ACKs for top commit:
  tcharding:
    ACK dae42bef9de0af8d605fa73ba06f39c576732ccc
  Kixunil:
    ACK dae42bef9de0af8d605fa73ba06f39c576732ccc
  apoelstra:
    ACK dae42bef9de0af8d605fa73ba06f39c576732ccc successfully ran local tests

Tree-SHA512: 622fd49632d363ab88b5f1a30e11897d1aae36e22892738aa1... (continued)

Coverage Stats

91 of 110 new or added lines in 15 files covered. (82.73%)

2 existing lines in 2 files now uncovered.

19694 of 23805 relevant lines covered (82.73%)

15633.5 hits per line