• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

supabase / auth / 10605980831
69%

Build:
DEFAULT BRANCH: master
Ran 28 Aug 2024 11:39PM UTC
Jobs 1
Files 128
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

28 Aug 2024 11:33PM UTC coverage: 57.869% (-0.02%) from 57.885%
10605980831

push

github

web-flow
fix: apply shared limiters before email / sms is sent (#1748)

## What kind of change does this PR introduce?
* Fixes https://github.com/supabase/auth/issues/1236
* Reduces the number of false positives arising from validation errors
when counting rate limits for emails / sms sent
* This change applies the shared rate limiter for email and phone
functions before the actual email / sms is being sent out rather than at
the start of the request
* The `limitEmailOrPhoneSentHandler()` now initialises the rate limiters
and sets it in the request context so we can subsequently retrieve it
right before the email / sms is sent

## What is the current behavior?

Please link any relevant issues here.

## What is the new behavior?

Feel free to include screenshots if it includes visual changes.

## Additional context

Add any other context or screenshots.

53 of 106 new or added lines in 12 files covered. (50.0%)

16 existing lines in 1 file now uncovered.

9123 of 15765 relevant lines covered (57.87%)

55.64 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
75.23
0.28% internal/api/external.go
1
46.55
0.4% internal/api/identity.go
1
67.19
0.0% internal/api/invite.go
1
62.16
1.1% internal/api/magic_link.go
1
57.76
2.84% internal/api/resend.go
1
67.0
0.12% internal/api/signup.go
1
67.43
0.76% internal/api/user.go
2
81.97
-0.64% internal/api/phone.go
44
57.14
-3.51% internal/api/mail.go

Uncovered Existing Lines

Lines Coverage ∆ File
16
57.14
-3.51% internal/api/mail.go
Jobs
ID Job ID Ran Files Coverage
1 10605980831.1 28 Aug 2024 11:39PM UTC 128
57.87
GitHub Action Run
Source Files on build 10605980831
  • Tree
  • List 128
  • Changed 24
  • Source Changed 0
  • Coverage Changed 15
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • bf276ab4 on github
  • Prev Build on master (#10605747677)
  • Next Build on master (#10663558264)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc