rust-bitcoin / rust-bitcoin / 10605337270

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3255: fix: re-implement `Psbt` (de)serialization from/to readers/writers

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/cf129ad3142dbfccd8f5c1fab646ca23e24d56d3">cf129ad31 fix: re-implement (de)serialization from/to readers/writers (elsirion)

Pull request description:

  Fixes #3250.

  The serialization is less than ideal and still allocates a lot. I can understand not wanting to (ab)use the consensus encoding traits, but they have a pretty good interface, copying it and creating some `EncodePsbt` and `DecodePsbt` traits with similar interfaces would have been nice imo.

ACKs for top commit:
  Kixunil:
    ACK cf129ad3142dbfccd8f5c1fab646ca23e24d56d3
  apoelstra:
    ACK cf129ad3142dbfccd8f5c1fab646ca23e24d56d3 successfully ran local tests; LGTM -- I believe this is non-breaking, as does cargo-semver-checks, so we can backport this to 0.32

Tree-SHA512: d7f218164078d084320771381ba53400cad

Coverage Stats

26 of 26 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

19650 of 23741 relevant lines covered (82.77%)

15673.59 hits per line