rust-bitcoin / rust-bitcoin / 10596979066

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3256: Change `T::from_str(s)` to `s.parse::<T>()`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/a76d76eca118d9700ffabea074beac7f55a505a9">a76d76eca Change `T::from_str(s)` to `s.parse::<T>()` (Jamil Lambert, PhD)

Pull request description:

  As mentioned in issue #3234 `s.parse::<T>()` is more idiomatic and produces more helpful error messages.

  This has been changed in the main codebase, not including examples, rustdocs, and in the `test` modules.

  `use std::str::FromStr;` has been removed where this change makes it unnecessary.

  To close the issue it may also need to be changed in the examples and the `test` modules and `contributing.md` updated.

ACKs for top commit:
  Kixunil:
    ACK a76d76eca118d9700ffabea074beac7f55a505a9
  storopoli:
    ACK a76d76eca118d9700ffabea074beac7f55a505a9
  tcharding:
    ACK a76d76eca118d9700ffabea074beac7f55a505a9

Tree-SHA512: 18be389579ec5168c6d960e7d144dfff425

8 of 12 new or added lines in 5 files covered. (66.67%)

19645 of 23736 relevant lines covered (82.76%)

15688.24 hits per line