openSUSE / agama / 10580973830

72%

Build Type

push

github

Committed by web-flow

Commit Message

feat(storage): API support for storage settings (#1471)

A JSON schema for the storage config is defined by
https://github.com/openSUSE/agama/pull/1455. This PR adds support to the
D-Bus API to allow setting a JSON config following that new JSON schema:

~~~
org.opensuse.Agama.Storage1
  #SetConfig s
  #GetConfig s
~~~

## `#SetConfig`

For now, the `#SetConfig` D-Bus method admits 3 different JSON formats
for the given JSON config:

* Guided config
~~~
{ "storage": { "guided": ... } }
~~~

* New storage config
~~~
{ "storage": { ... } }
~~~

* Legacy AutoYaST config

~~~
{ "legacyAutoyastStorage": [ ... ] }
~~~

The plan is to make `#SetConfig` and `#GetConfig` only to work with a
*storage config* or a *legacy AutoYaST config*. The *guided config* is
still accepted by `#SetConfig` because the new *storage config* does not
offer all the options offered by *guided config* yet.
 
In the future, the *guided config* will be neither accepted nor reported
by `#SetConfig` and `#GetConfig` respectively. Nevertheless, a D-Bus
method accepting the *guided config* will still be offered as a
simplification of the *storage settings* to make easier to work with the
use cases supported by the web UI.

## `#GetConfig`

Currently, `#GetConfig` reports different config formats depending on
how the proposal was calculated:

* For the initial proposal: reports the *guided config*.
* If `#SetConfig` was called with *guided config*: reports *guided
config* (extended with mandatory volumes, etc).
* If `#SetConfig` was called with *storage config*: reports exactly the
given *storage config*.
* If `#SetConfig` was called with *legacy AutoYaST config*: reports
exactly the given *legacy AutoYaST config*.
* If `Storage1.Proposal#Calculate` was called: reports the *guided
config* (extended with mandatory volumes, etc).

In the future, `#GetConfig` will only report either the *storage config*
or the *legacy AutoYaST config*.

Run Details

1987 of 2868 branches covered (69.28%)

Branch coverage included in aggregate %.

102 of 110 new or added lines in 9 files covered. (92.73%)

44 existing lines in 3 files now uncovered.

21463 of 29847 relevant lines covered (71.91%)

35.98 hits per line