10571820421

Committed 26 Aug 2024 09:54PM UTC coverage: 85.153% (-0.09%) from 85.242%

Build # 10571820421

Build Type

push

github

Committed by

web-flow

Commit Message

Don't return `seq=0, duplicate=true` when processing duplicate messages asynchronously (#5827)

This issue was reported by Marco and Antithesis.

`seq=0, duplicate=true` would be returned if two duplicate messages
would be processed at the same time. The first will propagate, which
will take some time for a clustered stream, but then the second message
gets processed and rejected with `seq=0, duplicate=true` (without
`error`) which would be invalid.

One option to fix this is timing out the second publish and wait for the
original message to finish processing.
That fixes this issue, and the user would just retry the request and get
the valid sequence once the other message has gone through.

However, it could decrease message throughput when this is hit. An
alternative could be to throw an error, but if the user would always
retry if `err != nil` then they'd be "spamming" the same request until
the original message is fully propagated.

Would like to hear your thoughts :) 
Maybe this would be more suitable for 2.11.x as well?

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

Run Details

66302 of 77862 relevant lines covered (85.15%)

1214568.37 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.06

/src/github.com/nats-io/nats-server/server/monitor.go

Source Not Available

The file "src/github.com/nats-io/nats-server/server/monitor.go" isn't available on github. Either it's been removed, or the repo root directory needs to be updated.

nats-io / nats-server / 10571820421

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available

Source File
Press 'n' to go to next uncovered line, 'b' for previous