basilisp-lang / basilisp / 10566047725

99%

push

github

Align `basilisp.core/deref` with Clojure to use timeout in ms (#1008)

Hi,

could you please consider patch to update the `basilisp.core/deref`
timeout argument to us ms instead of secs. It addresses #1007

This is to align with the same in `clojure.core/deref`.

I have add a `promise` basilisp test and updated an existing `future`
one. The tests check that the timeout for an unfulfilled promise returns
within a range of 100ms. I believe this range provides sufficient buffer
to avoid interference from parallel processing on the host.

Thanks

---------

Co-authored-by: ikappaki <ikappaki@users.noreply.github.com>

1836 of 1843 branches covered (99.62%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

8471 of 8581 relevant lines covered (98.72%)

0.99 hits per line