tarantool / tarantool / 10558785647

86%

master: 88%

Build Type

push

github

Committed by locker

Commit Message

vinyl: do not discard run on dump/compaction abort if index was dropped

If an index is dropped while a dump or compaction task is in progress
we must not write any information about it to the vylog when the task
completes otherwise there's a risk of getting a vylog recovery failure
in case the garbage collector manages to purge the index from the vylog.

We disabled logging on successful completion of a dump task quite a
while ago, in commit 29e2931c66c5 ("vinyl: fix race between compaction
and gc of dropped LSM"), and for compaction only recently, in commit
ae6a02ebab0b ("vinyl: do not log dump if index was dropped"), but the
issue remains for a dump/compaction failure, when we log a discard
record for a run file we failed to write. These results in errors like:

```
ER_INVALID_VYLOG_FILE: Invalid VYLOG file: Run 6 deleted twice
```

or

```
ER_INVALID_VYLOG_FILE: Invalid VYLOG file: Run 5768 deleted but not registered
```

Let's fix these issues in exactly the same way as we fixed them for
successful dump/compaction completion - by skipping writing to vylog
in case the index is marked as dropped.

Closes #10452

NO_DOC=bug fix

(cherry picked from commit de59504c2)

Run Details

63005 of 114239 branches covered (55.15%)

6 of 6 new or added lines in 1 file covered. (100.0%)

14 existing lines in 6 files now uncovered.

93890 of 109293 relevant lines covered (85.91%)

2466988.34 hits per line