• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tarantool / tarantool / 10558758485
88%

Build:
DEFAULT BRANCH: master
Ran 26 Aug 2024 11:30AM UTC
Jobs 1
Files 514
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

26 Aug 2024 11:18AM UTC coverage: 87.219% (+0.005%) from 87.214%
10558758485

push

github

locker
vinyl: do not discard run on dump/compaction abort if index was dropped

If an index is dropped while a dump or compaction task is in progress
we must not write any information about it to the vylog when the task
completes otherwise there's a risk of getting a vylog recovery failure
in case the garbage collector manages to purge the index from the vylog.

We disabled logging on successful completion of a dump task quite a
while ago, in commit 29e2931c66c5 ("vinyl: fix race between compaction
and gc of dropped LSM"), and for compaction only recently, in commit
ae6a02ebab0b ("vinyl: do not log dump if index was dropped"), but the
issue remains for a dump/compaction failure, when we log a discard
record for a run file we failed to write. These results in errors like:

```
ER_INVALID_VYLOG_FILE: Invalid VYLOG file: Run 6 deleted twice
```

or

```
ER_INVALID_VYLOG_FILE: Invalid VYLOG file: Run 5768 deleted but not registered
```

Let's fix these issues in exactly the same way as we fixed them for
successful dump/compaction completion - by skipping writing to vylog
in case the index is marked as dropped.

Closes #10452

NO_DOC=bug fix

68294 of 121545 branches covered (56.19%)

6 of 6 new or added lines in 1 file covered. (100.0%)

23 existing lines in 9 files now uncovered.

100976 of 115773 relevant lines covered (87.22%)

2670403.39 hits per line

Jobs
ID Job ID Ran Files Coverage
1 10558758485.1 26 Aug 2024 11:30AM UTC 0
87.22
GitHub Action Run
Source Files on build 10558758485
Detailed source file information is not available for this build.
  • Back to Repo
  • de59504c on github
  • Prev Build on master (#10524735471)
  • Next Build on master (#10566226594)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc