qunitjs / qunit / 10551227596

90%

push

github

Build: Refactor QUnit.start() definition to inject self-reference

Follows-up 05e15baa332ca, which made this into a factory function,
but that has the downside of making the QUnit object not defined in
one object literal, which makes a few other things reasier to reason
about.

In a way, it's more honest to say that start is the product of a
factory function, but I'd prefer to maintain the simplicity of an
uncoupled literal declaration the entire API, in particular in prep
for native ESM export (ref https://github.com/qunitjs/qunit/issues/1551).

I'll accept in return the internal responsiblity to not call start()
"incorrectly" (i.e. before it is ready). This responsibility does not
leak into, complicate, break, or otherwise change the public API, and
is mitigated by a runtime detection, for the benefit of future
contributors and maintainers to QUnit.

17 of 21 new or added lines in 2 files covered. (80.95%)

1845 of 2042 relevant lines covered (90.35%)

3538.45 hits per line