feeph / libemc2101-python / 10549983511

93%

push

github

feat: cleanup interface and leverage inheritance (#51)

The initial implementation tried to separate the low-level interface to
the EMC2101's functionality from the high-level interfaces (PWM & DAC).
This lead to significant code duplication between EMC2101_Core and
EMC2101_PWM. This duplication would only get worse once EMC2101_DAC is
added.

The redesigned interface scraps that distinction and instead leverages
inheritance to remove code duplication. This is expected to result in a
cleaner and easier to manage code base.

notable changes:
 - remove code duplication between EMC2101_Core and EMC2101_PWM
 - rework the initialization logic for the low-level implementation
 - rename 'chip' and 'external' sensore to 'its' and 'ets'
   (the external temperature sensor had many different names - these
   have been cleaned up)
 - redesign lookup table into a low-level and an extended implementation
   (The low-level implementation exclusively supports steps and has no
   concept of a percentage or RPM. PWM and DAC implementation need to
   provide the required logic to convert Percentage and RPM into steps.)
 - eliminate no longer required intermediate functionality

134 of 136 new or added lines in 6 files covered. (98.53%)

696 of 748 relevant lines covered (93.05%)

0.93 hits per line