basilisp-lang / basilisp / 10539746224

99%

push

github

Notify all waiting threads on a promise delivery (#994)

Hi,

can you please consider patch to notify all waiting threads for a
promise delivery. It fixes #993

This patch addresses the issue where one or more threads waiting for the
delivery condition in `Promise.deref` were not being notified upon the
delivery. In the worst-case scenario, this could lead to threads
deadlocking while waiting indefinitely for the notification, or in the
case of a timeout, returning only after the timeout has expired.

I've added a test based on the originally reported scenario that checks
how long it takes for the delivery to be received.

The time it now takes for the original case to be notified of the
delivery is just above the sleep time of the secondary thread at 0.108
secs

```clojure
basilisp.user=> (import threading) (import time)
<module 'time' (built-in)>

basilisp.user=> (let [p (promise)
                      t (threading/Thread **
                                          :daemon true
                                          :target #(do
                                                     (println :1in)
                                                     (time/sleep 0.1)
                                                     (deliver p :hi)
                                                     (println :2in)
                                                     ))]
                  (.start t)
                  (let [start (time/time)
                        value (deref p 5 :time-out)]

                    (println :value value :duration-sec (- (time/time) start))))
:1in
:2in
:value :hi :duration-sec 0.10864090919494629
nil
```

Thanks

Relevant section in the python documentation about wait and release on a
conditional var at
https://docs.python.org/3/library/threading.html#condition-objects:

>Other methods must be called with the associated lock held. The
[wait()](https://docs.python.org/3/library/thread... (continued)

1832 of 1839 branches covered (99.62%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

8459 of 8569 relevant lines covered (98.72%)

0.99 hits per line