open-contracting / credere-backend / 10531581609

86%

main: 86%

Build Type

Pull #394

github

Committed by jpmckinney

Commit Message

chore: Align model with model_id nullability, except Application.lender non-nullable (like .credit_product since b3d05bf)

SQLModel would suggests making these two nullable, but doing so causes type errors. Making them non-nullable doesn't affect migrations or validation, since Application is not used as a request or response format.

https://sqlmodel.tiangolo.com/tutorial/relationship-attributes/define-relationships-attributes/#optional-relationship-attributes

Pull Request Pull Request #394: Fix Mypy errors and small fixes

Run Details

21 of 29 new or added lines in 5 files covered. (72.41%)

1 existing line in 1 file now uncovered.

1817 of 2108 relevant lines covered (86.2%)

0.86 hits per line