rust-bitcoin / rust-bitcoin / 10527005040

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3221: feat(bip158): compute canonical filter hash

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/96e0e720fd7ab8e990b2dbadc979e5f0d6599c36">96e0e720f feat(bip158): compute canonical filter hash (Rob N)

Pull request description:

  From [BIP-157](https://github.com/bitcoin/bips/blob/master/bip-0157.mediawiki#filter-headers)

  > The canonical hash of a block filter is the double-SHA256 of the serialized filter.

  If a user forgets the "double" in double-SHA256 they will be computing a nonsensical filter hash when this is easily handled by the API.

ACKs for top commit:
  Kixunil:
    ACK 96e0e720fd7ab8e990b2dbadc979e5f0d6599c36
  tcharding:
    ACK 96e0e720fd7ab8e990b2dbadc979e5f0d6599c36

Tree-SHA512: 5fc0b1632be2f81978146dee49aedcec01a

0 of 4 new or added lines in 1 file covered. (0.0%)

19653 of 23751 relevant lines covered (82.75%)

15632.03 hits per line