c-ares / c-ares / 10526468482

92%

Build Type

push

github

Committed by web-flow

Commit Message

systemd-resolved handle ESERVFAIL/EREFUSED on single label names (#863)

systemd-resolved will return `ESERVFAIL` or `EREFUSED` by default on
single label domain names. See
https://github.com/systemd/systemd/issues/34101

They've basically labeled this as a non-issue even though it appears to
be in violation of the RFCs for downstream systems being able to support
negative caching. I haven't tested with the suggested
`ResolveUnicastSingleLabel=yes`, but that's off by default so its
unlikely people even knows this exists.

Since systemd is very prevalent these days, we really don't have much of
a choice but to work around their design decisions. This PR implements
this support, but *only* on single label names as it likely isn't valid
otherwise. It also adds test cases to confirm this behavior.

Fixes #852 
Authored-By: Brad House (@bradh352)

Run Details

128 of 131 new or added lines in 5 files covered. (97.71%)

1 existing line in 1 file now uncovered.

20750 of 22601 relevant lines covered (91.81%)

12845.8 hits per line