tarantool / tarantool / 10522839598

88%

Build Type

push

github

Committed by locker

Commit Message

box: store space name and engine name in `index_def` for error reporting

This patch fixes a bug that was introduced by commit 8fc59b101c10 ("box:
add details to DML errors related to key validation"), which added helper
functions for initializing payloads of DML errors related to key
validation.

The problem was that after the space was deleted, a situation could occur
that the `space.def->name` was still needed to generate an error message
if the key format was incorrect in the `get()` call from `read_view`.

This is exactly what happened sometimes in the function `error_set_index`.
One of the bug reproducers was to try to `get()` with an incorrect key
format (`ER_EXACT_MATCH`) in `read_view` from deleted space.

The problem has been fixed: space name as well as engine name are also
`index_def` fields now. There is no need to search for space and get these
fields from it.

Also some other places where space name and engine name could be taken
from `index_def` has been fixed.

Needed for tarantool/tarantool-ee#787

NO_DOC=bugfix
NO_TEST=ee
NO_CHANGELOG=bug not released

Run Details

68312 of 121525 branches covered (56.21%)

46 of 50 new or added lines in 9 files covered. (92.0%)

21 existing lines in 13 files now uncovered.

100972 of 115771 relevant lines covered (87.22%)

2488298.17 hits per line