lightninglabs / taproot-assets / 10518296092

40%

main: 57%

Build Type

Pull #1103

github

Committed by Roasbeef

Commit Message

commitment: splits shouldn't inherit locktime from inputs

In this commit, we fix an existing bug related to lock times and split
commitments. Before this commit, if an input had a relative lock time,
then when we went to make the new split assets, we would _copy_ that
value into the split. This isn't correct as the input is
valid/confirmed, so we don't need to copy over the lock time
information.

The prior behavior would cause certain classes of spends to fail, as
we would be validating a new root asset that has no lock time, but the
root asset split inserted into the split commitment would be carrying
the old lock time. When verifying the split, we would set the lock times
of the split to that of the new asset:
https://github.com/lightninglabs/taproot-assets/blob/e893dee87/vm/vm.go#L305-L307.

As we copied over the lock time from the input, we would now effectively
invalid the split commitment.

Fixes https://github.com/lightninglabs/taproot-assets/issues/1099

Pull Request Pull Request #1103: commitment: splits shouldn't inherit locktime from inputs

Run Details

19 of 24 new or added lines in 5 files covered. (79.17%)

18 existing lines in 7 files now uncovered.

23958 of 59434 relevant lines covered (40.31%)

55118.72 hits per line