facebookincubator / TTPForge / 10510419717

64%

main: 67%

Pull #511

github

Create all directories before creating a new file (#511)

Summary:
From the golang 1.23 os/file.go
```
// Flags to OpenFile wrapping those of the underlying system. Not all
// flags may be implemented on a given system.
const (
	// Exactly one of O_RDONLY, O_WRONLY, or O_RDWR must be specified.
	O_RDONLY int = syscall.O_RDONLY // open the file read-only.
	O_WRONLY int = syscall.O_WRONLY // open the file write-only.
	O_RDWR   int = syscall.O_RDWR   // open the file read-write.
	// The remaining values may be or'ed in to control behavior.
	O_APPEND int = syscall.O_APPEND // append data to the file when writing.
	O_CREATE int = syscall.O_CREAT  // create a new file if none exists.
	O_EXCL   int = syscall.O_EXCL   // used with O_CREATE, file must not exist.
	O_SYNC   int = syscall.O_SYNC   // open for synchronous I/O.
	O_TRUNC  int = syscall.O_TRUNC  // truncate regular writable file when opened.
)
```

Which makes me think that we might want to call MkdirAll function before creating a file

Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/511

Resolves https://github.com/facebookincubator/TTPForge/issues/506

Differential Revision: D61658174

32 of 69 new or added lines in 4 files covered. (46.38%)

1791 of 2817 relevant lines covered (63.58%)

13.58 hits per line