rust-bitcoin / rust-bitcoin / 10509109540

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3200: hashes: Fix a bunch of bugs caused by broken CI script

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/009e74732321f9f3e6d09e158dd577a7d9ebca35">009e74732<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fda76d9f6233d503dba1092d21fb3fbc022d21b3"> CI: Put fuzz last in CRATES list (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/aed61bd2d42aee5de1909daebcd5eed105628a51">aed61bd2d</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fda76d9f6233d503dba1092d21fb3fbc022d21b3"> Implement FromStr and serde impls for siphash (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/f8846101ae285ea975a647a815ab5172865a20c2">f8846101a</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fda76d9f6233d503dba1092d21fb3fbc022d21b3"> siphash: Make functions inherent (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/321d82ca5315b668578d737fa83c100201bc59f2">321d82ca5</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fda76d9f6233d503dba1092d21fb3fbc022d21b3"> hashes: Pin in extra_test (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/42c7617a46b888cd6d7da5ba7ffca37c501d2ddb">42c7617a4</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fda76d9f6233d503dba1092d21fb3fbc022d21b3"> Fix shchemars test (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b6fda6517c154a49e3a901f8409a4196ac66ed22">b6fda6517</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fda76d9f6233d503dba1092d21fb3fbc022d21b3"> Implement JsonSchema for siphash::Hash (Tobin C. Harding)
1af6ff439 hashes: Feature gate hash_reader unit test (Tobin C. Harding)
5230d3309 Remove hash_reader from sha256t_hash_newtype (Tobin C. Harding)

Pull request description:

  This is just the bug fixes pulled out of #2861

  The root problem here is the bug described in https://github.com/rust-bitcoin/rust-bitcoin-maintainer-tools/issues/10

  This PR works around the bug by putting `fuzz` last in the list.

ACKs for top commit:
  apoelstra:
    ACK 009e74732321f9f3e6d09e158dd577a7d9ebca35; confirmed that local CI STILL does not pass after this; needs #3195 as well; but it is improved
  Kixunil:
    ACK 009e74732321f9f3e6d09e158dd577a7d9ebca35 but I'd much rather see the siphash problems addressed by splitting up the macro. I can make a PR for that (but just that) later.

Tree-SHA512: f72457000ceca71887b3f3473417497a233

2 of 22 new or added lines in 2 files covered. (9.09%)

19655 of 23738 relevant lines covered (82.8%)

15567.22 hits per line